Resolve some cases of #132279 by using the right typing mode in the next solver#156141
Open
jdonszelmann wants to merge 4 commits intorust-lang:mainfrom
Open
Resolve some cases of #132279 by using the right typing mode in the next solver#156141jdonszelmann wants to merge 4 commits intorust-lang:mainfrom
jdonszelmann wants to merge 4 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
jdonszelmann
force-pushed
the
use-right-typingmode
branch
4 times, most recently
from
bac5eb5 to
7d76533
Compare
Collaborator
|
Some changes occurred to constck cc @fee1-dead Some changes occurred to the CTFE machinery |
rustbot
added
S-waiting-on-review
lcnr
reviewed
May 4, 2026
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
jdonszelmann
force-pushed
the
use-right-typingmode
branch
from
7d76533 to
a59bc36
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@rustbot review |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
May 5, 2026
jdonszelmann
force-pushed
the
use-right-typingmode
branch
from
a59bc36 to
da70164
Compare
Contributor
Author
|
@bors r=lcnr |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
Author
|
@bors rollupo |
Contributor
|
Unknown command "rollupo". Run |
Contributor
Author
|
@bors rollup |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 6, 2026
… r=lcnr Resolve some cases of rust-lang#132279 by using the right typing mode in the next solver r? @lcnr Convert 3 FIXMEs of rust-lang#132279 to using the right typing mode when we can (`tcx.use_typing_mode_borrowck()`) Also resolves rust-lang#155093, which I closed
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 6, 2026
… r=lcnr Resolve some cases of rust-lang#132279 by using the right typing mode in the next solver r? @lcnr Convert 3 FIXMEs of rust-lang#132279 to using the right typing mode when we can (`tcx.use_typing_mode_borrowck()`) Also resolves rust-lang#155093, which I closed
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 6, 2026
… r=lcnr Resolve some cases of rust-lang#132279 by using the right typing mode in the next solver r? @lcnr Convert 3 FIXMEs of rust-lang#132279 to using the right typing mode when we can (`tcx.use_typing_mode_borrowck()`) Also resolves rust-lang#155093, which I closed
rust-bors Bot
pushed a commit
that referenced
this pull request
May 6, 2026
…uwer Rollup of 7 pull requests Successful merges: - #146273 (lint ImproperCTypes: refactor linting architecture (part 2)) - #156173 (Fewer global node_id_to_def_id lookups) - #155961 (Deny warnings in the test for crates that are available on stable) - #156130 (Fold/visit tweaks) - #156131 (Metadata macro/query cleanups) - #156141 (Resolve some cases of #132279 by using the right typing mode in the next solver) - #156202 (llvm: Use correct type for splat mask)
Contributor
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#156238), which was unapproved. |
jdonszelmann
force-pushed
the
use-right-typingmode
branch
from
da70164 to
ef8be30
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @lcnr
Convert 3 FIXMEs of #132279 to using the right typing mode when we can (
tcx.use_typing_mode_borrowck())Also resolves #155093, which I closed